-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#210): allowed value log in response policy evaluation #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredmaggiowski
changed the title
fix(#210): allowed value simplification
fix(210): allowed value simplification
Jun 28, 2023
fredmaggiowski
changed the title
fix(210): allowed value simplification
fix(#210): allowed value simplification
Jun 28, 2023
Pull Request Test Coverage Report for Build 5403545644
💛 - Coveralls |
davidebianchi
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please review it again, it wasn't complete and actually bugged |
davidebianchi
requested changes
Jun 28, 2023
Co-authored-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com>
fredmaggiowski
changed the title
fix(#210): allowed value simplification
fix(#210): allowed value log in response policy evaluation
Jun 29, 2023
…authz/rond into fix/allowed-log-in-response-policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowed documentation states:
Since the policy is actually returning the new body it is expected to return a single expression with value different from
true
To verify:
Note:
The
verifyAllowed
function is supposed to be an internal utility only for logging purposes; I would not use it to decide what to return since it is too lax, I'd still rely on theresults.Allowed
func for that until a better solution is found.