Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New FromConfig SDK #219

Merged
merged 6 commits into from
Jul 14, 2023
Merged

New FromConfig SDK #219

merged 6 commits into from
Jul 14, 2023

Conversation

davidebianchi
Copy link
Member

No description provided.

@davidebianchi davidebianchi added the enhancement New feature or request label Jul 12, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5533854174

  • 89 of 100 (89.0%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+6.0%) to 83.96%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/opaevaluator.go 43 46 93.48%
openapi/evaluators.go 16 20 80.0%
openapi/openapi_utils.go 16 20 80.0%
Files with Coverage Reduction New Missed Lines %
core/opaevaluator.go 1 88.24%
Totals Coverage Status
Change from base Build 5532628298: 6.0%
Covered Lines: 1696
Relevant Lines: 2020
💛 - Coveralls

Base automatically changed from feat/sdk-package to main July 13, 2023 16:23
@davidebianchi davidebianchi marked this pull request as ready for review July 13, 2023 17:48
fredmaggiowski
fredmaggiowski reviewed Jul 14, 2023
View reviewed changes
core/errors.go Outdated Show resolved Hide resolved
fredmaggiowski
fredmaggiowski approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredmaggiowski fredmaggiowski merged commit 8ce2333 into main Jul 14, 2023
6 checks passed
@fredmaggiowski fredmaggiowski deleted the feat/sdk-from-config branch July 14, 2023 15:03
This was referenced Jul 18, 2023
Open
Closed
@fredmaggiowski fredmaggiowski linked an issue Jul 18, 2023 that may be closed by this pull request
Add method to Get evaluator passing a rond config, without setup the oas #221
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredmaggiowski fredmaggiowski fredmaggiowski approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add method to Get evaluator passing a rond config, without setup the oas
3 participants
@davidebianchi @coveralls @fredmaggiowski