Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: go1.22 update for benchmark runs #332

Merged
merged 3 commits into from
Mar 14, 2024
Merged

ci: go1.22 update for benchmark runs #332

merged 3 commits into from
Mar 14, 2024

Conversation

fredmaggiowski
Copy link
Member

Update golang version to v1.22 for benchmark job

@fredmaggiowski fredmaggiowski added the github_actions Pull requests that update GitHub Actions code label Mar 14, 2024
@coveralls
Copy link

coveralls commented Mar 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8277765051

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.91%
Totals Coverage Status
Change from base Build 8277344491: 0.0%
Covered Lines: 2324
Relevant Lines: 2737
💛 - Coveralls

@fredmaggiowski fredmaggiowski marked this pull request as draft March 14, 2024 08:36
@fredmaggiowski
Copy link
Member Author

I noticed benchmark are actually failing but tee is capturing the make bench exit code and making the command exit with 0 even though they should fail!

@fredmaggiowski fredmaggiowski marked this pull request as ready for review March 14, 2024 08:40
@fredmaggiowski fredmaggiowski merged commit e22d102 into main Mar 14, 2024
10 checks passed
@fredmaggiowski fredmaggiowski deleted the ci/go122-benchmark branch March 14, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredmaggiowski @coveralls