Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add 0x notice #40

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: add 0x notice #40

merged 1 commit into from
Nov 8, 2024

Conversation

RodinGolodin
Copy link
Contributor

Reason

Closes: N/A

What's being changed

Addresses an inconsistency in the Validator Portal UI and the key generation tool. The tool generates BLS keys and proof of possession without the 0x prefix, while the docs require that the prefix be there. This PR adds a note to inform the user.

Checklist

  • I've reviewed my changes in a preview environment (click the link in the "Preview" column to view your latest changes).
  • For content changes, I've completed the self-review checklist.

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ronin-document ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 10:33am

@RodinGolodin RodinGolodin requested a review from dwi November 7, 2024 10:33
Copy link
Contributor

@dwi dwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RodinGolodin RodinGolodin merged commit afa10f7 into main Nov 8, 2024
3 of 4 checks passed
@RodinGolodin RodinGolodin deleted the docs/become-a-validator branch November 8, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants