Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow registering OutputFormats without file extension #58

Merged

Conversation

moozzi
Copy link
Member

@moozzi moozzi commented Aug 31, 2024

No description provided.

@moozzi moozzi self-assigned this Aug 31, 2024
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized later this will require changing how infer_from(path) works. Maybe it might be easier to have ext default to an empty String, since File.extname('foo') # => ''.

@postmodern postmodern added this to the 0.3.0 milestone Aug 31, 2024
@postmodern postmodern added enhancement New feature or request output-formats Output Formats labels Aug 31, 2024
@moozzi
Copy link
Member Author

moozzi commented Sep 1, 2024

But '' will be used for few different output formats..

@postmodern
Copy link
Member

@AI-Mozi hmm yeah. We should keep register :dir, '', Dir that way ronin-recon run --output path/to/dir will select the OutputFormats::Dir output format, but Archive/GitArchive should not specify a file extension and would need to be specified explicitly (ex: --output-format archive or --output archive:path/to/dir).

@postmodern postmodern merged commit bd86ca0 into 0.3.0 Sep 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request output-formats Output Formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants