Add IPRangeEnum specs
#77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postmodern
reviewed
Aug 15, 2023
| describe Ronin::Recon::Net::IPRangeEnum do | ||
| describe "#process" do | ||
| context "when there are ip in range" do | ||
| let(:ip_range) { Ronin::Recon::Values::IPRange.new('192.168.0.1/2') } |
There was a problem hiding this comment.
Use /30 which will only enumerate the last two bits of the IP address.
| end | ||
| end | ||
|
|
||
| context "when there is no ip in range" do |
There was a problem hiding this comment.
I don't think this edge-case should exist? A Values::IPRange will always cause IPs to be yielded. Even if the IP range is A.B.C.D/32 it will only yield Values::IP.new('A.B.C.D').
| end | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Maybe also add an edge-case with an IPv6 range?
moozzi
force-pushed
the
add_ip_range_enum_spec
branch
2 times, most recently
from
235cb37 to
44dbd65
Compare
|
Moved into #107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for #58