Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement CertSh worker #87

Merged
merged 3 commits into from
Oct 26, 2023
Merged

implement CertSh worker #87

merged 3 commits into from
Oct 26, 2023

Conversation

moozzi
Copy link
Member

@moozzi moozzi commented Oct 23, 2023

#35

@moozzi
Copy link
Member Author

moozzi commented Oct 23, 2023

The descriptions are a bit primitive :/

postmodern
postmodern requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed two minor things, but other than that looks good.

lib/ronin/recon/builtin/net/cert_sh.rb Outdated
summary 'Returns host from each domains certificate.'

description <<~DESC
Returns host from each domains certificate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should mention that it's querying cert.sh in the description and summary.

lib/ronin/recon/builtin/net/cert_sh.rb Outdated

certs.each do |cert|
if cert[:common_name]
yield Host.new(name: cert[:common_name])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Host.new() accepts a single String.

@postmodern
Copy link
Member

Also this needs a spec that ensure that it will yield the correct Hosts for the Domain.

@postmodern postmodern merged commit cf6d3cd into ronin-rb:main Oct 26, 2023
4 checks passed
@postmodern
Copy link
Member

Awesome work!

@postmodern postmodern added worker Worker class builtin Builtin Workers ssl SSL/TLS labels Oct 26, 2023
@postmodern postmodern added this to the 0.1.0 milestone Oct 26, 2023
@postmodern
Copy link
Member

Noticed this random network timeout error: https://github.com/ronin-rb/ronin-recon/actions/runs/6650106343/job/18069671524#step:5:63

Perhaps we should add a retry helper method that rescues Errno::ETIMEDOUT and does a retry possibly with a 1 second sleep, incremental counter with a maximum limit, or incremental back-off?

@moozzi moozzi mentioned this pull request Oct 27, 2023
Closed
moozzi added a commit to moozzi/ronin-recon that referenced this pull request Feb 4, 2024
@moozzi
Implement the Net::CertSh worker (ronin-rb#87)
5f5ddb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postmodern postmodern postmodern approved these changes

Assignees

@moozzi moozzi

Labels
builtin Builtin Workers ssl SSL/TLS worker Worker class
Projects
No open projects
Phase 2
Status: Done
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@moozzi @postmodern