Add subject_alt_names kwarg to Cert.generate
#463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postmodern
reviewed
Nov 23, 2023
| @@ -356,6 +357,11 @@ def self.generate(version: 2, | |||
| else cert.subject | |||
| end | |||
|
|
|||
| if subject_alt_names | |||
| extensions ||= {} | |||
| extensions = extensions.merge('subjectAltName' => subject_alt_names.join(', ')) | |||
There was a problem hiding this comment.
Hmm, depends if we want to accept raw subject-alt-name values or IP/hostname Strings. If we accept IP/hostname strings, then we'd want to check if the string is an IP address, and map it to either "DNS:#{value}" or "IP:#{value}".
postmodern
requested changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#445