-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add WordlistFile
specs
#13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed some minor code styling issues.
spec/wordlist_file_spec.rb
Outdated
it "must raise a DownloadFailed error" do | ||
expect { | ||
Ronin::Wordlists::WordlistFile.download("invalid.com") | ||
}.to raise_error(Ronin::Wordlists::DownloadFailed, "error message") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation is wrong.
spec/wordlist_file_spec.rb
Outdated
describe "#update" do | ||
context "if #url is not nil" do | ||
it "must download wordlist from url" do | ||
expect(Ronin::Wordlists::WordlistFile).to receive(:download).with(subject.url, subject.path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use described_class
instead of Ronin::Wordlists::WordlistFile
.
#1