Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WordlistFile specs #13

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Conversation

moozzi
Copy link
Member

@moozzi moozzi commented Oct 28, 2023

#1

Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed some minor code styling issues.

it "must raise a DownloadFailed error" do
expect {
Ronin::Wordlists::WordlistFile.download("invalid.com")
}.to raise_error(Ronin::Wordlists::DownloadFailed, "error message")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is wrong.

spec/wordlist_file_spec.rb Show resolved Hide resolved
spec/wordlist_file_spec.rb Show resolved Hide resolved
describe "#update" do
context "if #url is not nil" do
it "must download wordlist from url" do
expect(Ronin::Wordlists::WordlistFile).to receive(:download).with(subject.url, subject.path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use described_class instead of Ronin::Wordlists::WordlistFile.

spec/wordlist_file_spec.rb Show resolved Hide resolved
spec/wordlist_file_spec.rb Show resolved Hide resolved
@postmodern postmodern merged commit f86d1af into ronin-rb:main Nov 1, 2023
5 checks passed
@postmodern postmodern added this to the 0.1.0 milestone Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants