-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing word lists #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I can at least view the diff now with git diff main..zzJZzz/missing-word-lists
locally. There are so many new entries that GitHub is refusing to render the diff for me. A few things I noticed:
- All summaries must end with a
.
otherwise the linting tests complain.
This could be fixed with somevim
-fu. - One of the entries uses
seclist-
while others useseclists-
. I think we should standardize onseclists-
. - Should we use
SecLists-
orseclists-
? - This raises the question, should all wordlists which are downloaded from the
SecLists
repo, be prefixed withseclists-
/SecLists-
? - A few of the entry names have spaces in them. The wordlist name should at least try to match the file name (ex:
weakpass-Wordlist 38
->weakpass-Wordlist38
). - Remove all wordlists who's URL contains
Fuzzing/User-Agents/operating-platform
. Appears that these areUser-Agent
wordlists grouped by OS/platform. Apparently LGUser-Agent
strings add a random string to them, which causedSecLists
to generate a bunch of wordlist files that only contain one (!!)User-Agent
string. (ex: https://github.com/danielmiessler/SecLists/blob/master/Fuzzing/User-Agents/operating-platform/lg-4iqj.txt)
@zzJZzz nice work on writing a script to import the entries! I may also have to add more Category tags to better describe/group the wordlists. |
Ahh. The script caused some of those problems and then regex find and
replace only caught some of the others. Like you said, there're so many new
entries I go cross eyed 🤣.
I will get the spaces removed from the name.
Personally I like seclists-.
When you are searching for a word list do you know the name of it? Or go
window shopping till you find one you like? if so then the prefix seems
like the better way to go I think.
I will remove the operating platform URLs
I'll add the . To the summaries.
Thanks again for your comments and assistance!
…On Tue, Jul 9, 2024, 5:52 PM Postmodern ***@***.***> wrote:
@zzJZzz <https://github.com/zzJZzz> nice work on writing a script to
import the entries!
I may also have to add more Category tags to better describe/group the
wordlists.
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMYO64BK3R7SI4V3P5AR7ALZLRLQTAVCNFSM6AAAAABKTSZ3P6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJYG44TGMBQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hello. I addressed the changes above. with the exception of
As I wasn't sure if there was an official decision. I can go back and change, or perhaps another issue could be created? In addition: I did remove a few wordlists that gave me trouble when I imported. Maybe about 40? The original repo had spaces in between which showed up on import. If that's how they are supposed to be then I can add in the %20, or if they should have the _ or -, I can do that too. When I tried to find those wordlists from the actual website and tried out some of the urls to see, I did not have success so I removed for now. |
I would use hyphens, or whatever the filename of the wordlist is without the file extension (ex:
This is a good point. We should check if the wordlist URLs do not return 404. I can probably add tests to do a |
@zzJZzz I have now added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's extra whitespace on the end of :categories:
. You can do %s/\v\s+$//g
in vim
to strip any tailing whitespace.
@postmodern My apologies for the delay. My day job had some deadlines and we had some everyday life things. I believe all of the linting is passing now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove any wordlists that contain withcount
or have .csv
in the file extension, as we cannot process multi-column wordlist files.
Also, I think YAML Array elements should be indented by two spaces:
:categories:
- one
- two
Sorry this is taking so long. :(
.github/workflows/lint_wordlists.yml
Outdated
@@ -17,6 +17,7 @@ jobs: | |||
runs-on: ubuntu-latest | |||
steps: | |||
- uses: actions/checkout@v4 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These newlines don't seem necessary.
Apologies for the delay. Traveling for work which is rare, and caring for sick family. I did do my first CTF! Should be good to go now. |
Finally merged! 🎉 |
Yeah! Awesome!! Thanks for your patience!
…On Fri, Nov 15, 2024, 10:15 PM Postmodern ***@***.***> wrote:
Finally merged! 🎉
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMYO64CUAFVJO5X6PZ7TCUT2A22FJAVCNFSM6AAAAABKTSZ3P6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQGM3DGNZYGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Details
eg:
vs.
13
I changed it to include where the list is from and what it contained likeweakpass-wordlist.
from the PR comments. The goal was to add more detail so it would be more apparent at first glance.Testing