Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gh-1625] fix creating session keys from session keys. #1657

Closed
wants to merge 2 commits into from

Conversation

feliciss
Copy link
Collaborator

@feliciss feliciss commented May 7, 2024

Summary

  1. Add test cases for creating session keys from session keys.
  2. Check params and logic within TxValidateResult.

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-rooch-portal-v1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 6:06am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 6:06am

Then cmd: "move run --function 0x3::empty::empty --session-key {{$.session-key[-1].authentication_key}}"
Then assert: "{{$.move[-1].execution_info.status.type}} == executed"

# session key from session key
Then cmd: "session-key create --app-name test --app-url https://test-seed.rooch.network --session-key {{$.session-key[-1].authentication_key}} --scope 0x3::empty::empty"
Then cmd: "move run --function 0x3:cargo test -p testsuite --test integration:empty::empty --session-key {{$.session-key[-1].authentication_key}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can not run testsuite in testsuite case.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove it.

@jolestar
Copy link
Contributor

jolestar commented May 13, 2024

How is this PR going? We plan to release a new version.

@feliciss
Copy link
Collaborator Author

How is this PR going? We plan to release a new version.

Pushed a new hash for review. Still on-going.

@jolestar
Copy link
Contributor

jolestar commented May 13, 2024

@feliciss
Copy link
Collaborator Author

@feliciss discuss in https://discord.com/channels/1078938449974935592/1237388145893445672

I don't have permissions to send messages to that thread.

@jolestar
Copy link
Contributor

fixed in #1690

@jolestar jolestar closed this May 16, 2024
@feliciss feliciss deleted the #1625 branch May 16, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] SessionKey can create SessionKey
2 participants