Support freeze package upgrading #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
jolestar
reviewed
Jun 4, 2024
jolestar
approved these changes
Jun 4, 2024
| object::transfer_extend(package, tx_context::sender()); | ||
| // TODO: should we transfer the Package object to tx sender or package id address? | ||
| create_package(module_object, package_id, tx_context::sender()); | ||
| is_upgrade = false; | ||
| }; | ||
| let package = borrow_mut_package(module_object, package_id); |
There was a problem hiding this comment.
Check if the Package is frozen and abort the transaction with an error code from the module_store.
| if (!exists_package(module_object, package_id)) { | ||
| let package = object::add_object_field_with_id(module_object, package_id, Package {}); | ||
| object::transfer_extend(package, tx_context::sender()); | ||
| // TODO: should we transfer the Package object to tx sender or package id address? |
There was a problem hiding this comment.
The package id address must equal the tx sender?
There was a problem hiding this comment.
This is not always the same. For example, sequencer publish the framework modules, the tx_sender should be sequencer?
There was a problem hiding this comment.
The sequencer can only upgrade the framework modules and can not publish a new package with the framework address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #704
Add Upgrade policy of package, and support freezeing package.