Merged
Conversation
Embed the build/version info into binaries and display a startup banner. Added ldflags -X main.version to the GitHub Actions build steps and added build-args: APP_VERSION to the Docker build/push step so the Docker image can be stamped with the release tag. Dockerfile now accepts ARG APP_VERSION (defaulting to dev) and uses it in the go build ldflags. cmd/pluck/main.go now defines a version var and an ASCII art banner and prints the banner and version on startup (also added fmt import). Also updated README example to use /data/downloads/complete as the watch directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embed the build/version info into binaries and display a startup banner. Added ldflags -X main.version to the GitHub Actions build steps and added build-args: APP_VERSION to the Docker build/push step so the Docker image can be stamped with the release tag. Dockerfile now accepts ARG APP_VERSION (defaulting to dev) and uses it in the go build ldflags. cmd/pluck/main.go now defines a version var and an ASCII art banner and prints the banner and version on startup.