Package osprey rpc as zip file #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmttt
requested review from
a team,
BinaryFiddler,
EXBreder,
ayubun,
haileyok and
jaredmiller13
as code owners
EXBreder
approved these changes
Jan 13, 2026
Remove unnecessary google proto dependencies - these should come from the protobuf/grpcio-tools packages, not be bundled in osprey-rpc.
cmttt
commented
Jan 13, 2026
| cd "$(dirname "$0")" | ||
|
|
||
| glob=(./proto/**/*.proto) | ||
| glob=(./proto/osprey/**/*.proto) |
Collaborator
Author
There was a problem hiding this comment.
@EXBreder I think this is fine so we don't have to generate all the google protos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add automated release workflow for
osprey-rpcpackageSummary
This PR adds infrastructure to automatically build and publish the
osprey-rpcPython package as release assets whenever a new GitHub release is created. It also regenerates the proto files to fix import issues.Changes
New: GitHub Actions Release Workflow
.github/workflows/release-osprey-rpc.ymlthat triggers on release publishosprey_rpcsdist usinguv build.tar.gzand.ziparchives (zip required for downstream pycross/Bazel compatibility)Proto Regeneration
osprey_rpc/src/osprey.rpc.labelsmodulegoogle.*proto dependencies (protobuf, api, iam, pubsub, bigtable, etc.)Why
The
discord_apiservice needs to consumeosprey-rpcas a dependency to communicate with the Osprey coordinator. Discord's build system (Bazel + pycross) requires dependencies to be:.zipfiles (not.tar.gz)This workflow enables
discord_apito depend onosprey-rpcvia:Testing
.ziparchive is consumable by downstream projectsModuleNotFoundError)uv.lockregenerated with uv 0.9.24 to match CI