Skip to content

Commit

Permalink
Emit const variables only once (#13614)
Browse files Browse the repository at this point in the history
Otherwise they are emitted as internal and we get double-construction
and -destruction on the same memory address due to the way we promote
internal declarations in KeepLocalGVPass.

According to upstream tests, the de-duplication doesn't work on Windows
(yet), but I think this problem is severe enough to fix it on the other
platforms sooner rather than later.

Fixes #13429
  • Loading branch information
hahnjo authored and jenkins committed Oct 3, 2023
1 parent 45318c5 commit a3fa6e2
Showing 1 changed file with 37 additions and 0 deletions.
37 changes: 37 additions & 0 deletions test/CodeGeneration/const.C
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
//------------------------------------------------------------------------------
// CLING - the C++ LLVM-based InterpreterG :)
//
// This file is dual-licensed: you can choose to license it under the University
// of Illinois Open Source License or the GNU Lesser General Public License. See
// LICENSE.TXT for details.
//------------------------------------------------------------------------------

// RUN: cat %s | %cling 2>&1 | FileCheck %s

extern "C" int printf(const char*, ...);

struct A {
int val;
A(int v) : val(v) {
printf("A(%d), this = %p\n", val, this);
}
~A() {
printf("~A(%d), this = %p\n", val, this);
}
int getVal() const { return val; }
};

const A a(1);
// CHECK: A(1), this = [[PTR:.+]]

a.val
// CHECK-NEXT: (const int) 1
a.getVal()
// CHECK-NEXT: (int) 1
a.val
// CHECK-NEXT: (const int) 1
a.getVal()
// CHECK-NEXT: (int) 1

// CHECK-NEXT: ~A(1), this = [[PTR]]
// CHECK-NOT: ~A

0 comments on commit a3fa6e2

Please sign in to comment.