Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diagnostic failure if an object return different types for begin() and end() #516

Closed
wants to merge 1 commit into from

Conversation

lackhole
Copy link
Contributor

@lackhole lackhole commented Jan 21, 2024

Fix compilation error when obj->begin() and obj->end() return different type.

This case is uncommon, but used sometimes. E.g, unbounded std::ranges::iota_view

@lackhole lackhole changed the title Fix diagnostic failure if an object that return different types for begin() and end() Fix diagnostic failure if an object return different types for begin() and end() Jan 21, 2024
@pcanal pcanal self-assigned this Jan 22, 2024
@pcanal pcanal self-requested a review January 22, 2024 20:19
@pcanal
Copy link
Member

pcanal commented Jan 22, 2024

This fixes #517

@pcanal

This comment was marked as resolved.

@lackhole
Copy link
Contributor Author

lackhole commented Jan 23, 2024

@pcanal Are the errors caused by the changes?

@pcanal
Copy link
Member

pcanal commented Jan 23, 2024

Humm ... I did not notice the PR was open against the intended repository.

We need to have the PR done at https://github.com/root-project/root/pulls.
I.e. you will need to reapply this change to the Cling code within the ROOT repository.

Thanks.

@ferdymercury
Copy link
Contributor

Humm ... I did not notice the PR was open against the intended repository.

@pcanal is there a way to disable PRs on this repo? Or to have a phsft-bot 'warning' users that this is a mirror and that PR should be rather done to root ?

@pcanal pcanal closed this Apr 12, 2024
@pcanal pcanal reopened this Apr 12, 2024
@pcanal
Copy link
Member

pcanal commented Apr 12, 2024

It is okay-ish to have PR against this repo for user that work solely on Cling to provide feedback, however they indeed can not be merged and after verification against the Cling-CI they should be migrated (by us or the user) to a ROOT PR.

@ferdymercury
Copy link
Contributor

Closing here as the user already moved the PR to ROOT: root-project/root#14968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants