export types.d.ts #310
Merged
export types.d.ts #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linev
reviewed
May 29, 2024
package.json
Outdated
| @@ -133,4 +137,4 @@ | |||
| "core-js": false, | |||
| "dompurify": false | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Please do not remove newline at the end
There was a problem hiding this comment.
done, sorry, my linter didn't like that
linev
approved these changes
May 29, 2024
linev
pushed a commit
that referenced
this pull request
May 29, 2024
* export types.d.ts * reset newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follow a discussion on the root forum: https://root-forum.cern.ch/t/typescript-problem-with-jsroot-could-not-find-a-declaration-file-for-module-jsroot/59497
Exposing types.d.ts in requirement
This fix the issue, but the MR should be reviewed by an expert in javascript