[ntuple] Add RNTupleSingleProcessor
#17134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Test Results 18 files 18 suites 4d 2h 33m 57s ⏱️ Results for commit 8c5a984. ♻️ This comment has been updated with latest results. |
vepadulano
approved these changes
Nov 29, 2024
jblomer
approved these changes
Dec 5, 2024
|
Indeed, this processor should also be able to handle empty ntuples. I have an implementation for this, but it required a bit more refactoring than I initially forsaw, so I propose to merge this PR as-is, and I will open a new one to address the empty ntuple case. |
The `RNTupleSingleProcessor` processes one single RNTuple, using the same interfaces as the `RNTupleChainProcessor` and `RNTupleJoinProcessor`. The point of adding this processor is that this way, the other processors can use a unified interface for loading entries, without having to know whether they are dealing with a single RNTuple or a composed one.
enirolf
force-pushed
the
ntuple-processor-base
branch
from
84d59d0 to
8c5a984
Compare
enirolf
changed the title
RNTupleBaseProcessorRNTupleSingleProcessor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RNTupleSingleProcessorprocesses one single RNTuple, using the same interfaces as theRNTupleChainProcessorandRNTupleJoinProcessor. The point of adding a base processor is that this way, the other processors can use a unified interface for loading entries, without having to know whether they are dealing with a single RNTuple or a composed one.This PR is part of a bigger set of (foreseen) changes, collected and tracked in #17132.