[ntuple] Refactor and add more RNTupleJoinProcessor tests
#17271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the mismatch between the test ntuple description and what was actually created. In addition, attempts to make a clearer separation between join scenarios, and adds a few extra test cases.
enirolf
force-pushed
the
ntuple-processor-join-test-refactor
branch
from
f1e15a1 to
c781a27
Compare
Test Results 18 files 18 suites 3d 14h 29m 11s ⏱️ For more details on these failures, see this check. Results for commit c781a27. |
jblomer
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the mismatch between the test ntuple description and what was actually created. In addition, attempts to make a clearer separation between join scenarios, and adds a few extra test cases.
Related to #17132.