[ntuple] Improve RNTupleProcessor entry number bookkeeping
#17290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More clearly distinguishes between the number of entries processed and the entry number (relative to the open page source) currently loaded.
Test Results 18 files 18 suites 4d 3h 28m 53s ⏱️ For more details on these failures, see this check. Results for commit 64bd2d1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the bookkeeping of entries in the
RNTupleProcessor. Most importantly, a clearer distinction is made between the current entry number (relative to the currently open page source) and the number of entries processed. There was an incorrectness where this value was equal, whereas (assuming we linearly process one page source)fNEntriesProcessedshould be higher thanfLocalEntryNumber(e.g., after loading the first entry,fNEntriesProcessed == 1, andfLocalEntryNumber == 0).In the process, some variables have been renamed to better capture their meaning.
As a consequence of this refactoring, the
RNTupleSingleProcessorcan now also handle empty ntuples.Related to #17132.