[io] Extract tkey walk logic from TFile::Map()

[silverweed]

This Pull request:

refactors TFile::Map into 2 methods: Map and WalkTKeys. The latter contains the logic of traversing the TKeys in the file and returns an array with information about keys, gaps and errors. Map now simply calls that method and prints out the relevant information, in the same format as before.

The main advantage of splitting WalkTKeys is that it can be used by other places (like unit tests or client code) that are interested in the internal TKey structure.

Checklist:

• tested changes locally
• updated the docs (if necessary)

[jblomer]

I like the idea! In this approach, all keys are loaded in memory before printing the information. Do we need a piecewise / cursor based API?

[silverweed]

In this approach, all keys are loaded in memory before printing the information. Do we need a piecewise / cursor based API?

This is possible, although a file containing 1 million keys would only occupy 68 MiB of memory for the TKeyMapNodes (for reference, the 3.8 GB ttjet_13tev benchmark dataset has 278470 keys - about 38 MiB of memory). This is not counting the classname/keyname/key title strings; with them the figure is likely doubled or so.
Generating the array seems to be also quite fast on my machine (<1s in debug mode)

[pcanal]

The current observed maximum number of baskets in TTree is 50 millions baskets ... and only because it reaches the 1Gb limit for the TTree object. It will/can grow larger once we lift the 1Gb limit and can already reach larger size with RNTuple (probably not quite as easily due to page size being larger than basket sizes).

Nonetheless that is 3.1 GiB of memory for the TKeyMapNodes .... so indeed I would recommend some sort of iterators mechanism (other-wise the code simply 'crash/out-of-memory' for large files.

[github-actions]

Test Results

    18 files      18 suites   4d 7h 5m 39s ⏱️
 2 687 tests  2 687 ✅ 0 💤 0 ❌
46 670 runs  46 670 ✅ 0 💤 0 ❌

Results for commit 2bcccda.

♻️ This comment has been updated with latest results.

[silverweed]

@pcanal is there anything else blocking this PR?

[pcanal]

LGTM. Thanks.