Fix numba tests with Python 3.13+ #17972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowadays the ROOTTEST_IGNORE* cmake variables are not necessary anymore. Instead, a proper use of the PYTHON_DEPS argument to the various ADD_TEST functions will ensure that the Python dependency is present in the system at configuration time, and disable the test if it is not found.
Python 3.13 changes the semantics of the builtin `locals()` function, see https://docs.python.org/3/library/functions.html#locals. For our case, it means that the call to `locals()` that happens at function-scope in the Numba decorator will not modify the `locals()` dictionary, thus the JITted pywrapper function will not appear in the dictionary. Ensure this happens by binding `locals()` to a local variable, which is actually modified by `exec()`.
guitargeek
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits descriptions