Skip to content

Conversation

vgvassilev
Copy link
Member

No description provided.

@vgvassilev
Copy link
Member Author

@guitargeek, can you take a look at the failures and interpret them for us? IIUC, there is nothing clad related...

Copy link

github-actions bot commented Sep 21, 2025

Test Results

    21 files      21 suites   3d 10h 36m 19s ⏱️
 3 678 tests  3 678 ✅ 0 💤 0 ❌
75 424 runs  75 424 ✅ 0 💤 0 ❌

Results for commit 612cfc8.

♻️ This comment has been updated with latest results.

@hahnjo hahnjo added the clean build Ask CI to do non-incremental build on PR label Sep 22, 2025
@hahnjo hahnjo closed this Sep 22, 2025
@hahnjo hahnjo reopened this Sep 22, 2025
@hahnjo
Copy link
Member

hahnjo commented Sep 22, 2025

You probably want a clean build because there may be files left over when just changing the GIT_TAG version

@guitargeek
Copy link
Contributor

@guitargeek, can you take a look at the failures and interpret them for us? IIUC, there is nothing clad related...

There are comparison failures with numeric gradients now that fail all over the place, so the current failures seem Clad related.

I'll have time to investigate this later in the afternoon after the ROOT meeting. I can create a reproducer and open an issue in Clad a usual.

@vgvassilev
Copy link
Member Author

Thank you, @guitargeek!

cc: @PetroZarytskyi

@guitargeek
Copy link
Contributor

I'm checking now Clad master with Petros possible fix on top:

@guitargeek
Copy link
Contributor

Note that while the ROOT CI will pass now, there is still a regression in Clad master that broke the CMS Combine likelihoods:

@vgvassilev
Copy link
Member Author

Note that while the ROOT CI will pass now, there is still a regression in Clad master that broke the CMS Combine likelihoods:

* [Regression in Clad `master` when aliasing array parameters in inner function vgvassilev/clad#1573](https://github.com/vgvassilev/clad/issues/1573)

Ah, okay, thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean build Ask CI to do non-incremental build on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants