[ntuple] automatic evolution in and out std::atomic #19937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblomer
force-pushed
the
ntuple-evolution-atomic
branch
from
9ce4dd5 to
ac97cad
Compare
Test Results 21 files 21 suites 3d 13h 52m 56s ⏱️ For more details on these failures, see this check. Results for commit 73ef349. ♻️ This comment has been updated with latest results. |
silverweed
reviewed
Sep 23, 2025
| { | ||
| auto model = ROOT::RNTupleModel::Create(); | ||
| auto a = model->MakeField<std::atomic<std::int32_t>>("a"); | ||
| auto i = model->MakeField<std::int32_t>("i"); |
There was a problem hiding this comment.
Maybe we should also test with a class type (and one where is_lock_free is false)
hahnjo
reviewed
Sep 24, 2025
There was a problem hiding this comment.
In principle, the changes look neat and small. I'm wondering about the error case: When reconciling an RAtomicField with something on-disk that is not std::atomic, we unconditionally delegate to the item field. Is that maybe confusing for the error message? (I don't have an immediate idea how to do it better)
|
|
||
| void ROOT::RAtomicField::ReconcileOnDiskField(const RNTupleDescriptor &desc) | ||
| { | ||
| static const std::vector<std::string> prefixes = {"std::atomic<"}; |
Allow for std::atomic<T> --> T (or compatible) automatic conversion and vice versa.
jblomer
force-pushed
the
ntuple-evolution-atomic
branch
from
ac97cad to
73ef349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for std::atomic --> T (or compatible) automatic conversion and vice versa.