Skip to content

Conversation

linev
Copy link
Member

@linev linev commented Sep 25, 2025

RWebWindow::ClearOnClose let destroy handle when all connections are closed by widget - or when widget is destroyed.

But if pending connection is not reconnected and finally removed, ClearOnClose was not emptied.
Therefore add such check when pending connections processed.

Add separate timeout for reconnecting of pending connections.
Default is 15 seconds - while in such case browser process already exists and only JavaScript has to be reinitialized.
Can be changed via WebGui.ReconnectTmout rootrc parameter.

If such timeout zero or negative - connection is not possible to reconnect.

While pending connection can be removed after timeout, invoke clear on close at that moment
Use shorter timeout to restart some specific widget after pressing Ctrl-R.
For that specially mark such connection with the falg.
Default reconnect timeout will be 15 s
When reconnect timeout is negative,
closed connection will be immediately destoryed
So no new connection will be possible.
In that case cleanup handle will be invoked immediately
It directly calls fWebWinow->Sync() where pending actions can be performed.
Can be used to run some async actions from outside
@linev linev requested a review from silverweed September 25, 2025 11:17
Copy link

github-actions bot commented Sep 25, 2025

Test Results

    21 files      21 suites   3d 20h 16m 29s ⏱️
 3 679 tests  3 678 ✅  0 💤 1 ❌
75 439 runs  75 427 ✅ 10 💤 2 ❌

For more details on these failures, see this check.

Results for commit 3c147ef.

♻️ This comment has been updated with latest results.

@linev linev requested a review from silverweed September 30, 2025 14:52
@linev linev merged commit 420b0e1 into root-project:master Sep 30, 2025
22 of 26 checks passed
@linev linev deleted the rbrowser_close branch September 30, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants