-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[webgui] handle ClearOnClose for pending connections #19978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+36
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While pending connection can be removed after timeout, invoke clear on close at that moment
Use shorter timeout to restart some specific widget after pressing Ctrl-R. For that specially mark such connection with the falg. Default reconnect timeout will be 15 s
When reconnect timeout is negative, closed connection will be immediately destoryed So no new connection will be possible. In that case cleanup handle will be invoked immediately
It directly calls fWebWinow->Sync() where pending actions can be performed. Can be used to run some async actions from outside
silverweed
reviewed
Sep 25, 2025
Test Results 21 files 21 suites 3d 20h 16m 29s ⏱️ For more details on these failures, see this check. Results for commit 3c147ef. ♻️ This comment has been updated with latest results. |
silverweed
reviewed
Sep 26, 2025
Pluse several other places
f89dd2b
to
3c147ef
Compare
silverweed
reviewed
Sep 26, 2025
silverweed
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RWebWindow::ClearOnClose
let destroy handle when all connections are closed by widget - or when widget is destroyed.But if pending connection is not reconnected and finally removed,
ClearOnClose
was not emptied.Therefore add such check when pending connections processed.
Add separate timeout for reconnecting of pending connections.
Default is 15 seconds - while in such case browser process already exists and only JavaScript has to be reinitialized.
Can be changed via
WebGui.ReconnectTmout
rootrc parameter.If such timeout zero or negative - connection is not possible to reconnect.