tree: factor out the check for associative container. #19992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix one case that had not been updated to support multimap/multiset.
…9610) --------- Co-authored-by: Philippe Canal <pcanal@fnal.gov>
The flow for reading an STL associative container is:
(a) Read branch count
(b) load sub-branch data into a staging/temporary area
(c) copy/insert that data into the associative container
Previously doing a direct read like:
tree->GetBranch("map.second")->GetEntry(e);
was leading to 'write' into deleted memory.
This allow to document the 2 sets of similar test at the same place to contrast them
Potential microoptimization.
Test Results 18 files 18 suites 2d 20h 48m 55s ⏱️ For more details on these failures, see this check. Results for commit aebb09e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #19938
Fixes #19963
Fix one case that had not been updated to support multimap/multiset.