[v638][RF] Don't normalize over non-dependents when compiling RooFormulaVar #20778
+156
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `depList` list is filled already with the subset of normalization variables that the pdf depends on (see `getObservables(nset, depList)` a few lines before. Therefore, the check `dependsOn(depList)` is redundant and causes unnecessary performance overheads, as the whole compute graph of the pdf has to be traversed. We might as well check if `depList` is empty for the same logic. (cherry picked from commit c1608ac)
This is done to fix clang-format failures in the CI. (cherry picked from commit 202843a)
Don't normalize pdfs over non-dependents in `RooFormulaVar::compileForNormSet()`. This fixes use cases where pdfs that don't depend on any observables are used for their unnormalized `RooAbsPdf::evaluate()` shape as functions. Even thought technically not allowed because evaluating pdfs without a normalization set is undefined, this pattern is used a lot in the wild, so we need to support it also in the new vectorizing evaluation backend. A unit test that covers the original user-reported problem is also added. (cherry picked from commit 25f8bbd)
Test Results 21 files 21 suites 3d 17h 25m 29s ⏱️ Results for commit 52e837a. |
guitargeek
merged commit 5ca24d1
into
root-project:v6-38-00-patches
29 of 31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20772