Skip to content

Conversation

@vepadulano
Copy link
Member

No description provided.

@vepadulano vepadulano self-assigned this Feb 3, 2026
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's good to make sure the linter checks are green!

I only have a concern about the Python code formatting, unrelated to this PR: the check in the CI doesn't seem to work correctly. @siliataider, maybe you can understand what's happening there? If I remember correctly, you introduced these checks.

Image

@siliataider
Copy link
Contributor

LGTM, it's good to make sure the linter checks are green!

I only have a concern about the Python code formatting, unrelated to this PR: the check in the CI doesn't seem to work correctly. @siliataider, maybe you can understand what's happening there? If I remember correctly, you introduced these checks.
Image

Thanks @guitargeek for catching this! Indeed there was a recent change in the logic of computing the diff, this PR should take care of the issue # #21130

@vepadulano vepadulano merged commit 09d0883 into root-project:master Feb 3, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants