[Python] Avoid direct cppyy import in SOFIE Keras parser
#21187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I try to move away from exposing `cppyy` directly as a package, so we can hide it in the ROOT implementation details and don't collide with other installed `cppyy` packages.
Test Results 22 files 22 suites 3d 14h 14m 17s ⏱️ Results for commit 0eee3b2. ♻️ This comment has been updated with latest results. |
lmoneta
approved these changes
Feb 9, 2026
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
LGTM!
And thanks also to apply the ruff to the Python files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try to move away from exposing
cppyydirectly as a package, so we can hide it in the ROOT implementation details and don't collide with other installedcppyypackages.This follows up on #20871, but I didn't want to request the avoidance of cppyy imports there, because that policy only came after the new Keras parser was developed.
Ruff warnings and formatting errors are fixed in separate commits.