[CMake] Use OUTPUT_NAME if defined in ROOT_GENERATE_DICTIONARY

[aphecetche]

This Pull request:

Fixes the logic used to infer the base name used to generate the libXXX.dylib|so, libXXX_rdict.pcm and libXXX.rootmap when using the MODULE option of the ROOT_GENERATE_DICTIONARY CMake macro, in the case where the OUTPUT_NAME of XXX has been set prior to the call to ROOT_GENERATE_DICTIONARY.

Checklist:

• [X ] tested changes locally
• updated the docs (if necessary) => not necessary (?)

[guitargeek]

Hi, thanks for the PR! Let's see if it works.

However, I think this goes in the opposite direction of 498165d, which was fixing #15792.

Do you maybe have a simple CMake reproducer for the problem that you try to fix?

[github-actions]

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 06d8fe2.

[aphecetche]

@guitargeek actually it's trying to fix the same bug as #15792. I did not do my homework correctly and a) did not check past issues thoroughly b) forgot I'm using Root 6.32 daily and not the latest master (so I did try my fix in my current setup and "pasted-in" in master to prepare the PR w/o too much thinking). Sorry about that.

[guitargeek]

No problem! Why would you assume that a niche problem like this is fixed in master and check in the closed issues before starting to code. I also wouldn't have done that 🙂