[6.38] [PyROOT] Fix a GIL deadlock in THx.Fit #21198
Merged
+79
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TH1.Fit might call into Python functions, which would require the GIL to be held. If TH1.Fit holds it, though, the process deadlocks. Here, the GIL is released before TH1.Fit, which runs fully in C++ anyway. Fix root-project#21080. (cherry picked from commit e8a739a)
This saves startup times and collects TH1 tests in one place. (cherry picked from commit 9372b50)
The timeout of the test is reduced because the deadlock would otherwise show only after 1500s. (cherry picked from commit b14edf9)
(cherry picked from commit d48c865)
dpiparo
requested review from
bellenot,
dpiparo and
vepadulano
as code owners
Test Results 19 files 19 suites 3d 5h 12m 43s ⏱️ Results for commit 787d682. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #21129, requested by @dpiparo
For your information @hageboeck