Avoid need for setting RPATH with multiple dependent ACLiC libraries #21216
+8
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acro" This reverts commit df8b468.
…raries By adding the directory where ACLiC is generating the shared library to its RPATH, we can enable use cases of creating multiple shared libraries via ACLiC that depend on each other within the same session. Such functionality is embodied by the tests found in roottest/root/io/arrayobject directory and was previously working, so now it is restored while still keeping the same RPATH-based approach.
vepadulano
added
in:Build System
clean build
Test Results 22 files 22 suites 3d 14h 16m 6s ⏱️ For more details on these failures, see this check. Results for commit 03387df. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion with @pcanal we agreed that the changes in this commit df8b468 were underlining a backwards-incompatible behaviour change in ACLiC. On the one hand, that commit was done in the spirit of the larger move to a fully RPATH-based build of ROOT (and thus also ROOT facilities that invoke the compiler). At the same time, it should be possible to still allow the use case of building multiple dependent shared libraries on the fly. This commit proposes to do so by adding the directory where ACLiC is generating said library to its RPATH, so that dependent libraries can also find it. Note that this still requires the libraries to stay where they were produced, i.e. it doesn't make them (more) relocatable. But this was never done, so improving on that is beyond the scope of this commit.