Skip to content

[graf] Move the current libjpg builtin to the latest version and the builtin directory #21525

Draft
dpiparo wants to merge 3 commits intoroot-project:masterfrom
dpiparo:builtin_libjpeg
Draft

[graf] Move the current libjpg builtin to the latest version and the builtin directory #21525
dpiparo wants to merge 3 commits intoroot-project:masterfrom
dpiparo:builtin_libjpeg

Conversation

@dpiparo
Copy link
Member

@dpiparo dpiparo commented Mar 6, 2026

This PR does two things:

  1. Adds in the builtins directory libjpeg in its latest released version, 3.1.3, as sources, to stick to the current way of doing in ROOT. The way in which sources are pruned, e.g. of tests, is clearly described.
  2. Removes the old builtin, buried in graf2d/asimage/src/libAfterImage/libjpeg and adapts CMake to take advantage of the newly located builtin.

This was possible only thanks to the assistance and CMake experience of @hageboeck , whom I thank.

@couet @guitargeek @bellenot FYI

@dpiparo dpiparo self-assigned this Mar 6, 2026
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Test Results

    20 files      20 suites   2d 18h 6m 40s ⏱️
 3 809 tests  3 808 ✅ 1 💤 0 ❌
68 789 runs  68 780 ✅ 9 💤 0 ❌

Results for commit 063157a.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant