change Person.isPrivate() to getPrivate()

rootsdev · Oct 6, 2016 · b1a3098 · b1a3098
1 parent 1c1c949
commit b1a3098
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/src/core/Person.js b/src/core/Person.js
@@ -63,12 +63,12 @@ Person.prototype.init = function(json){
 };
 
 /**
- * Check whether the person is marked as private
+ * Get the private flag
  * 
  * @returns {Boolean} private
  */
-Person.prototype.isPrivate = function(){
-  return !!this.private;
+Person.prototype.getPrivate = function(){
+  return this.private;
 };
 
 /**

diff --git a/test/core/Person.js b/test/core/Person.js
@@ -40,7 +40,7 @@ describe('Person', function(){
       ]
     });
     assert.equal(person.getId(), 'testPerson');
-    assert.equal(person.isPrivate(), true);
+    assert.equal(person.getPrivate(), true);
     assert.equal(person.getGender().getType(), 'http://gedcomx.org/Female');
     assert.equal(person.getNames()[0].getNameForms()[0].getFullText(), 'Joanna Hopkins');
     assert.equal(person.getFacts()[0].getDate().getFormal(), '+2001-04-09');
@@ -77,7 +77,7 @@ describe('Person', function(){
       ]
     });
     assert.equal(person.getId(), 'testPerson');
-    assert.equal(person.isPrivate(), true);
+    assert.equal(person.getPrivate(), true);
     assert.equal(person.getGender().getType(), 'http://gedcomx.org/Female');
     assert.equal(person.getNames()[0].getNameForms()[0].getFullText(), 'Joanna Hopkins');
     assert.equal(person.getFacts()[0].getDate().getFormal(), '+2001-04-09');
@@ -92,7 +92,7 @@ describe('Person', function(){
       .addName(GedcomX.Name().addNameForm(GedcomX.NameForm().setFullText('Joanna Hopkins')))
       .addFact(GedcomX.Fact().setDate(GedcomX.Date().setFormal('+2001-04-09')).setPlace(GedcomX.PlaceReference().setOriginal('Farm house')));
     assert.equal(person.getId(), 'testPerson');
-    assert.equal(person.isPrivate(), true);
+    assert.equal(person.getPrivate(), true);
     assert.equal(person.getGender().getType(), 'http://gedcomx.org/Female');
     assert.equal(person.getNames()[0].getNameForms()[0].getFullText(), 'Joanna Hopkins');
     assert.equal(person.getFacts()[0].getDate().getFormal(), '+2001-04-09');

diff --git a/test/records/Person.js b/test/records/Person.js
@@ -34,7 +34,7 @@ describe('Person', function(){
       ]
     });
     assert.equal(person.getId(), 'testPerson');
-    assert.equal(person.isPrivate(), true);
+    assert.equal(person.getPrivate(), true);
     assert.equal(person.getPrincipal(), true);
     assert.equal(person.getGender().getType(), 'http://gedcomx.org/Female');
     assert.equal(person.getNames()[0].getNameForms()[0].getFullText(), 'Joanna Hopkins');
@@ -51,7 +51,7 @@ describe('Person', function(){
       .addName(GedcomX.Name().addNameForm(GedcomX.NameForm().setFullText('Joanna Hopkins')))
       .addFact(GedcomX.Fact().setDate(GedcomX.Date().setFormal('+2001-04-09')).setPlace(GedcomX.PlaceReference().setOriginal('Farm house')));
     assert.equal(person.getId(), 'testPerson');
-    assert.equal(person.isPrivate(), true);
+    assert.equal(person.getPrivate(), true);
     assert.equal(person.getPrincipal(), true);
     assert.equal(person.getGender().getType(), 'http://gedcomx.org/Female');
     assert.equal(person.getNames()[0].getNameForms()[0].getFullText(), 'Joanna Hopkins');

diff --git a/test/rs/Person.js b/test/rs/Person.js
@@ -39,7 +39,7 @@ describe('Person', function(){
     });
     assert.equal(person.getLiving(), true);
     assert.equal(person.getId(), 'testPerson');
-    assert.equal(person.isPrivate(), true);
+    assert.equal(person.getPrivate(), true);
     assert.equal(person.getGender().getType(), 'http://gedcomx.org/Female');
     assert.equal(person.getNames()[0].getNameForms()[0].getFullText(), 'Joanna Hopkins');
     assert.equal(person.getFacts()[0].getDate().getFormal(), '+2001-04-09');
@@ -58,7 +58,7 @@ describe('Person', function(){
       .setDisplay(GedcomX.DisplayProperties().setName("Joanna Hopkins").setGender("Female"));
     assert.equal(person.getLiving(), true);
     assert.equal(person.getId(), 'testPerson');
-    assert.equal(person.isPrivate(), true);
+    assert.equal(person.getPrivate(), true);
     assert.equal(person.getGender().getType(), 'http://gedcomx.org/Female');
     assert.equal(person.getNames()[0].getNameForms()[0].getFullText(), 'Joanna Hopkins');
     assert.equal(person.getFacts()[0].getDate().getFormal(), '+2001-04-09');