Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify domain_list and look_up for user and code base #200

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

RayStick
Copy link
Contributor

@RayStick RayStick commented Feb 17, 2025

Closes #199

References #184

Checklist for the author of this PR:

  • [if package files were edited] I have run these checks locally:
    • devtools::document() to generates the .Rd files from any updated roxygen comments.
    • lintr::lint_package(path = ".") to check for style compliance and syntax issues.
    • codemetar::write_codemeta() to ensures the metadata file is up to date.
    • devtools::check() for a comprehensive package check. I have resolved any warnings or errors, or written them here in the PR, for discussion.
  • The code base and the documentation files match (they both reflect any recent changes).
  • The title of this PR is clear and self-explantory.
  • I have added any appropriate labels to this PR.
  • This PR is now ready for review (and I have removed the draft PR status).

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 17, 2025
@RayStick RayStick changed the title simplify the wa domain_list and look_up are used Simplify domain_list and look_up for user and code base Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
R/metadata_map.R 71.42% 2 Missing ⚠️
Files with missing lines Coverage Δ
R/inputs_collect.R 98.78% <100.00%> (+4.49%) ⬆️
R/map_compare.R 100.00% <100.00%> (+2.19%) ⬆️
R/plotting.R 100.00% <ø> (ø)
R/user_interactions.R 100.00% <100.00%> (ø)
R/metadata_map.R 74.25% <71.42%> (+1.31%) ⬆️

@RayStick RayStick marked this pull request as ready for review February 17, 2025 16:27
@RayStick RayStick merged commit 6fc615a into main Feb 17, 2025
9 checks passed
@RayStick RayStick deleted the improve_lookup_table branch February 17, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify how lookup and domain_list are used by the user
1 participant