Skip to content

Commit

Permalink
prepare for submission
Browse files Browse the repository at this point in the history
  • Loading branch information
fmichonneau committed Apr 3, 2018
1 parent dc017ee commit c23db6d
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 26 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Authors@R: c(
comment = c("ORCID" = "0000-0002-3835-8062")),
person("David", "Winter", role="aut",
comment = c("ORCID" = "0000-0002-6165-0029")),
person("Scott", "Chameberlain", role="rev",
person("Scott", "Chamberlain", role="rev",
comment = c("ORCID" = "0000-0003-1444-9135")))
Description: An interface to the 'Open Tree of Life' API to retrieve
phylogenetic trees, information about studies used to assemble the synthetic
Expand Down
43 changes: 18 additions & 25 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,42 +1,35 @@
## Resubmission

- This addresses the non-canoncial URL in the vignette, and the warning
regarding the vignettes being more recent than the files found in inst/doc.

## Comments

- This submission addresses the comment by Prof Ripley from 2017-02-27. The use
of the suggested package 'fulltext' is now conditional.

- This submission addresses the Warnings seen on the CRAN checks

## Test environments

- local Ubuntu 16.10, R 3.3.2
- Ubuntu 12.04 (travis-ci), R 3.3.2
- Windows with R-hub (R 3.3.2 and R Under development (2017-02-28 r72286)
- local Debian, using R Under development (unstable) (2017-03-01 r72295)
- local Ubuntu 17.10, R 3.4.4
- Ubuntu 14.04 (travis-ci), R 3.3.3, R 3.4.4, and R devel (2018-04-02 r74501)
- Windows with R-hub (R Under development (2018-03-30 r74499)

## R CMD check results

- There were no ERRORs or WARNINGs

- There was 1 NOTE
- There was 3 NOTEs

```
* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Francois Michonneau <francois.michonneau@gmail.com>'
License components with restrictions and base license permitting such:
BSD_2_clause + file LICENSE
File 'LICENSE':
YEAR: 2016
COPYRIGHT HOLDER: Francois Michonneau, Joseph W. Brown, David Winter
Possibly mis-spelled words in DESCRIPTION:
API (2:45, 9:54)
phylogenetic (10:5, 12:60)
* Maintainer: ‘Francois Michonneau <francois.michonneau@gmail.com>’
* Unknown, possibly mis-spelled, fields in DESCRIPTION:
‘X-schema.org-keywords’ ‘X-schema.org-isPartOf’ ‘X-schema.org-relatedLink’
* checking DESCRIPTION meta-information ... NOTE
Authors@R field gives persons with non-standard roles:
Scott Chamberlain [rev] (0000-0003-1444-9135): rev
```

The "unknown" fields in DESCRIPTION corresponds to the codemeta metadata standard for the package as indicated here: https://github.com/ropensci/codemetar#using-the-description-file

The role "rev" stands for reviewer and it is my understanding that it will fully supported starting with R 3.5.0


## Downstream dependencies

* taxize: no WARNING or NOTE generated.

0 comments on commit c23db6d

Please sign in to comment.