Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draft: Improve: build & install operation #18

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

draft: Improve: build & install operation #18

wants to merge 4 commits into from

Conversation

130s
Copy link
Member

@130s 130s commented Nov 17, 2023

TBD

130s added 2 commits November 17, 2023 16:29
@130s
Improve: Relocate a package so that one step in build instruction can…
8c069ca 
… be eliminated

Signed-off-by: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
@130s
Improve: Omit build for {assests, scenes} so that a few steps in buil…
964cd20 
…d instruction can be eliminated

Signed-off-by: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
@130s 130s mentioned this pull request Nov 17, 2023
Open
1 task
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20cc171) 19.50% compared to head (bbe2d52) 19.50%.

❗ Current head bbe2d52 differs from pull request most recent head 6c6c929. Consider uploading reports for the commit 6c6c929 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   19.50%   19.50%           
=======================================
  Files          98       98           
  Lines       10009    10009           
=======================================
  Hits         1952     1952           
  Misses       8057     8057

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@130s
Fix: Missing dependency (compensated by a tool called 'roscompile')
5569e4e 
Signed-off-by: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
@130s 130s force-pushed the fix-buildoperations branch from bbe2d52 to 5569e4e Compare November 17, 2023 22:45
@130s
Fix: redundant deps that are likely added by roscompile but rosdep co…
6c6c929 
…mplains about

Signed-off-by: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@130s