Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added biased tool drag toolpath modifier #279

Merged

Conversation

DavidSpielman
Copy link
Contributor

@DavidSpielman DavidSpielman commented Nov 8, 2024

This PR adds the original tool drag toolpath modifier that was overwritten in #251

@marip8 can you verify that the toolpath modifier produces the intended behavior? While testing, it seems that for the same region the biased modifier splits the section into two arcs (approaches and departures) while the tool drag modifier only has one arc section.

@marip8
Copy link
Member

marip8 commented Nov 8, 2024

While testing, it seems that for the same region the biased modifier splits the section into two arcs (approaches and departures) while the tool drag modifier only has one arc section.

Can you post a picture of this?

@DavidSpielman
Copy link
Contributor Author

DavidSpielman commented Nov 8, 2024

While testing, it seems that for the same region the biased modifier splits the section into two arcs (approaches and departures) while the tool drag modifier only has one arc section.

Can you post a picture of this?

The behavior I described above seems to occur when there is a mismatch between the tool radius of the circular approach and departure modifiers and the tool radius in the tool drag toolpath modifiers. I have resolved this by ensuring the tool radius parameters match

However, when the tool radius for the circular approach and departure tool path modifiers are equal, some of the tool path waypoints are not translated sufficiently in the z direction from the part (see the below images). This is resulting in a failed motion plan.

Current Tool Drag Orientation Toolpath Modifier
Screenshot from 2024-11-08 14-55-34

Biased Tool Drag Orientation Toolpath Modifier
biased_tool_drag

@marip8
Copy link
Member

marip8 commented Nov 11, 2024

The behavior I described above seems to occur when there is a mismatch between the tool radius of the circular approach and departure modifiers and the tool radius in the tool drag toolpath modifiers. I have resolved this by ensuring the tool radius parameters match

I think there is always a risk that subsequent tool path modifiers can be misconfigured in a way that causes problems, but I think the individual pieces work as expected. To solve your particular problem, we could make a new tool path modifier plugin that combines the circular approach/departure with the tool drag modifier and also makes some checks that the tool and circle radius make sense

@marip8
Copy link
Member

marip8 commented Nov 11, 2024

Can you also add this new tool path modifier to the unit test?

@marip8 marip8 merged commit 368aed5 into ros-industrial:dev Nov 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants