enable pedantic warnings as errors

CMakeLists.txt

@@ -2,6 +2,10 @@ cmake_minimum_required(VERSION 3.10)
 
 project(ROSProjectManager VERSION 12.0)
 
+if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+    add_compile_options(-Werror -Wall -Wextra -Wpedantic -Wsuggest-override)
+endif()
+
 if(${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
     add_link_options("-Wl,-z,relro,-z,now,-z,defs")
 endif()

src/project_manager/ros_build_system.cpp

@@ -20,39 +20,39 @@ void ROSBuildSystem::triggerParsing()
     guardParsingRun().markAsSuccess();
 }
 
-bool ROSBuildSystem::addFiles(ProjectExplorer::Node *context, const Utils::FilePaths &filePaths, Utils::FilePaths *notAdded)
+bool ROSBuildSystem::addFiles(ProjectExplorer::Node *context, const Utils::FilePaths &/*filePaths*/, Utils::FilePaths */*notAdded*/)
 {
     // update entire workspace project
     dynamic_cast<ROSProject *>(context->getProject())->refresh();
     return true;
 }
 
-ProjectExplorer::RemovedFilesFromProject ROSBuildSystem::removeFiles(ProjectExplorer::Node *context, const Utils::FilePaths &filePaths, Utils::FilePaths *notRemoved)
+ProjectExplorer::RemovedFilesFromProject ROSBuildSystem::removeFiles(ProjectExplorer::Node */*context*/, const Utils::FilePaths &/*filePaths*/, Utils::FilePaths */*notRemoved*/)
 {
     return ProjectExplorer::RemovedFilesFromProject::Ok;
 }
 
-bool ROSBuildSystem::deleteFiles(ProjectExplorer::Node *context, const Utils::FilePaths &filePaths)
+bool ROSBuildSystem::deleteFiles(ProjectExplorer::Node */*context*/, const Utils::FilePaths &/*filePaths*/)
 {
     return true;
 }
 
-bool ROSBuildSystem::canRenameFile(ProjectExplorer::Node *context, const Utils::FilePath &oldFilePath, const Utils::FilePath &newFilePath)
+bool ROSBuildSystem::canRenameFile(ProjectExplorer::Node */*context*/, const Utils::FilePath &/*oldFilePath*/, const Utils::FilePath &/*newFilePath*/)
 {
     return true;
 }
 
-bool ROSBuildSystem::renameFile(ProjectExplorer::Node *context, const Utils::FilePath &oldFilePath, const Utils::FilePath &newFilePath)
+bool ROSBuildSystem::renameFile(ProjectExplorer::Node */*context*/, const Utils::FilePath &/*oldFilePath*/, const Utils::FilePath &/*newFilePath*/)
 {
     return true;
 }
 
-bool ROSBuildSystem::addDependencies(ProjectExplorer::Node *context, const QStringList &dependencies)
+bool ROSBuildSystem::addDependencies(ProjectExplorer::Node */*context*/, const QStringList &/*dependencies*/)
 {
     return true;
 }
 
-bool ROSBuildSystem::supportsAction(ProjectExplorer::Node *context, ProjectExplorer::ProjectAction action, const ProjectExplorer::Node *node) const
+bool ROSBuildSystem::supportsAction(ProjectExplorer::Node */*context*/, ProjectExplorer::ProjectAction action, const ProjectExplorer::Node */*node*/) const
 {
     static const std::set<ProjectAction> possible_actions = {
         ProjectAction::AddNewFile,

src/project_manager/ros_project.cpp

@@ -444,7 +444,7 @@ void ROSProject::asyncUpdateCppCodeModel(bool success)
 
 void ROSProject::buildCppCodeModel(const ROSUtils::WorkspaceInfo workspaceInfo,
                                    const Utils::FilePath projectFilePath,
-                                   const QStringList workspaceFiles,
+                                   const QStringList /*workspaceFiles*/,
                                    const Kit *k,
                                    const Utils::Environment &env,
                                    const ROSUtils::PackageInfoMap wsPackageInfo,

src/project_manager/ros_project_wizard.h

@@ -59,7 +59,7 @@ class ROSImportWizardPage : public Utils::WizardPage
     explicit ROSImportWizardPage(QWidget *parent = 0);
     ~ROSImportWizardPage();
 
-    bool isComplete() const;
+    bool isComplete() const override;
 
     bool forceFirstCapitalLetterForFileName() const;
     void setForceFirstCapitalLetterForFileName(bool b);

src/project_manager/ros_run_step.h

@@ -54,7 +54,7 @@ class RunStep : public ProjectExplorer::ProjectConfiguration
 
     virtual bool immutable() const;
     virtual bool runInGuiThread() const;
-    virtual void cancel();
+    virtual void cancel() override;
 
     void fromMap(const Utils::Store &map) override;
     void toMap(Utils::Store &map) const override;

src/project_manager/ros_run_steps_page.h

@@ -50,8 +50,8 @@ class ToolWidget : public Utils::FadingPanel
 public:
     ToolWidget(QWidget *parent = 0);
 
-    void fadeTo(qreal value);
-    void setOpacity(qreal value);
+    void fadeTo(qreal value) override;
+    void setOpacity(qreal value) override;
 
     void setRunStepEnabled(bool b);
     void setUpEnabled(bool b);

src/project_manager/ros_settings_page.h

@@ -84,9 +84,9 @@ class ROSSettingsPage : public Core::IOptionsPage
     explicit ROSSettingsPage(QSharedPointer<ROSSettings> &settings,
                              QObject *parent = nullptr);
 
-    QWidget *widget();
-    void apply();
-    void finish();
+    QWidget *widget() override;
+    void apply() override;
+    void finish() override;
 
 private:
     const QSharedPointer<ROSSettings> m_settings;