Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flake8 errors (Unnecessary list comprehension) #928

Closed

Conversation

SubaruArai
Copy link
Contributor

@SubaruArai SubaruArai commented Aug 17, 2023

Related: #929
With both merged, the ci should be fixed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.54% ⚠️

Comparison is base (05b49e4) 74.82% compared to head (9879894) 74.28%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #928      +/-   ##
==========================================
- Coverage   74.82%   74.28%   -0.54%     
==========================================
  Files          44       44              
  Lines        3364     3364              
==========================================
- Hits         2517     2499      -18     
- Misses        847      865      +18     
Files Changed Coverage Δ
src/rosdep2/platforms/osx.py 51.93% <0.00%> (ø)
src/rosdep2/sources_list.py 84.24% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SubaruArai SubaruArai changed the title fix flake8 errors fix flake8 errors (Unnecessary list comprehension) Aug 17, 2023
Copy link

@peci1 peci1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cottsay
Copy link
Member

cottsay commented Apr 9, 2024

Sorry, I missed this one. This was fixed by #943.

@cottsay cottsay closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants