[stdeb] Make Replaces3 to work on the same versions than Conflicts3#100
Open
[stdeb] Make Replaces3 to work on the same versions than Conflicts3#100
Conversation
Makes little sense to make `Replaces:` to work only in the non existing version (the one in vcs4l release). The PR change to work in the same scenarios than `Conflicts:`
j-rivero
requested review from
claraberendsen and
leander-dsouza
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 26.96% 26.96%
=======================================
Files 31 31
Lines 2240 2240
Branches 393 393
=======================================
Hits 604 604
Misses 1576 1576
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leander-dsouza
changed the title
leander-dsouza
approved these changes
Feb 26, 2026
Member
leander-dsouza
left a comment
leander-dsouza
left a comment
There was a problem hiding this comment.
LGTM 🎉
Since there are no matching versions between vcstool and vcs2l, the replacement should happen if the tag is semantically lower than ros-infrastructure/vcs2l.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes little sense to make
Replaces:to work only in the non existing version (the one in vcs4l release). The PR change to work in the same scenarios thanConflicts:.