-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup_robot_localization.rst #650
base: master
Are you sure you want to change the base?
Conversation
@coffinfish I think actually the code should be fixed to use If you update these launch files and the name in the config file, that would have the same impact: https://github.com/search?q=repo%3Aros-navigation%2Fnavigation2_tutorials%20ekf_node&type=code This tutorial page is shared with Pre- and Post- Jazzy's setup, so I think we should keep the name the same across the board so it doesn't break either users' setup guide |
c2363ad
to
439e9a5
Compare
Changed in command, config file, and launch file. Signed-off-by: Cindy Hua <cindysongh@gmail.com>
b233674
to
0043243
Compare
Signed-off-by: Cindy Hua <cindysongh@gmail.com>
That makes a lot of sense. I (hopefully) ended up doing the changes you mentioned above correctly. I kept the most of the original documentation the same and only changed the config yaml file and the name parameter in the launch file. |
@coffinfish There's also a few places in this repository you missed on the following pages (grep / search to find):
The other PR is also missing a couple, but once those are added, this is an easy merge! Thanks for the help and noticing this discrepancy! |
Replaced instances of ekf_filter_node with ekf_node
The commands refer to the node as ekf_filter_node when it should be ekf_node (as it is named in the launch file and ekf.yaml file). Apologies if this was intended behaviour.