Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup_robot_localization.rst #650

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

coffinfish
Copy link

@coffinfish coffinfish commented Feb 27, 2025

Replaced instances of ekf_filter_node with ekf_node

The commands refer to the node as ekf_filter_node when it should be ekf_node (as it is named in the launch file and ekf.yaml file). Apologies if this was intended behaviour.

@SteveMacenski
Copy link
Member

SteveMacenski commented Mar 4, 2025

@coffinfish I think actually the code should be fixed to use ekf_filter_node so that it is consistent with the other distribution branches. We have tutorials for pre-Jazzy using ekf_filter_node and switching the name seems unncessary in the code.

If you update these launch files and the name in the config file, that would have the same impact: https://github.com/search?q=repo%3Aros-navigation%2Fnavigation2_tutorials%20ekf_node&type=code

This tutorial page is shared with Pre- and Post- Jazzy's setup, so I think we should keep the name the same across the board so it doesn't break either users' setup guide

Changed in command, config file, and launch file.

Signed-off-by: Cindy Hua <cindysongh@gmail.com>
@coffinfish coffinfish force-pushed the coffinfish-patch-1 branch from b233674 to 0043243 Compare March 5, 2025 02:05
Signed-off-by: Cindy Hua <cindysongh@gmail.com>
@coffinfish
Copy link
Author

That makes a lot of sense. I (hopefully) ended up doing the changes you mentioned above correctly. I kept the most of the original documentation the same and only changed the config yaml file and the name parameter in the launch file.

@SteveMacenski
Copy link
Member

SteveMacenski commented Mar 10, 2025

@coffinfish There's also a few places in this repository you missed on the following pages (grep / search to find):

  • We will first launch ``display.launch.py`` which launches the robot state publisher that provides the ``base_link`` => ``sensors`` transformations in our URDF, launches Gazebo that acts as our physics simulator, and provides the ``odom`` => ``base_link`` from the differential drive plugin or the ekf_node. It also launches RViz which we can use to visualize the robot and sensor information.
  • A usual robot setup consists of at least the wheel encoders and IMU as its odometry sensor sources. When multiple sources are provided to ``robot_localization``, it is able to fuse the odometry information given by the sensors through the use of state estimation nodes. These nodes make use of either an Extended Kalman filter (``ekf_node``) or an Unscented Kalman Filter (``ukf_node``) to implement this fusion. In addition, the package also implements a ``navsat_transform_node`` which transforms geographic coordinates into the robot’s world frame when working with GPS.

The other PR is also missing a couple, but once those are added, this is an easy merge! Thanks for the help and noticing this discrepancy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants