-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RPP] Jerk limited trajectory generation #2816
Open
angstrem98
wants to merge
21
commits into
ros-navigation:main
Choose a base branch
from
memristor:rpp-motion-profile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4ca6b48
Include ruckig
angstrem98 f72e6df
Add member variables
angstrem98 1014e15
Declare parameters
angstrem98 cf77875
Motion profiles init
angstrem98 0e954d3
Remaining path length calculation
angstrem98 c31209a
rotateToHeading using motion profile
angstrem98 2f4190f
Add RPP code with motion profile
angstrem98 39b3ef0
Remove old velocity scaling near goal
angstrem98 645d975
Improve shouldRotateToGoalHeading
angstrem98 e3a875b
Fix linter, code style
angstrem98 f46184a
Fix end of path detection
angstrem98 7f1e4e5
rotate to path remove unnecessary angle modification
angstrem98 4eb8c39
fix rotating_ not being reset to false
angstrem98 7d44ab4
merge main, solve conflicts
angstrem98 7c7d265
normalize angle using ros/angles
angstrem98 c615a72
switch raw memory management to unique_ptr
angstrem98 2e698e2
remove rotating_ variable
angstrem98 e1ddd74
remove min_approach_linear_velocity since it is not used anymore
angstrem98 10d0d4f
dynamic params
angstrem98 2f461e0
readd tests
angstrem98 03cf93c
update docs, force trapezoidal velocity profile on default
angstrem98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is reliably run at the
controller_frequency
rate, may that be substituted instead of keeping timers?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, it is run at mentioned frequency. I am not using timers, just tracking system time. The problem is, I need to reset some internal states in case goal has been cancelled or goal checker stopped calling
computeVelocityCommands
. There is no such callback that allows me to do that, so my solution is to check ifcomputeVelocityCommands
has not been called for 4 control loop durations. If that's true, we have to reset internal states since controller has been idle for a while. You can look at the logic here:https://github.com/memristor/navigation2/blob/03cf93ce88499222ed5e599f1a5dad8e8572c50d/nav2_regulated_pure_pursuit_controller/src/regulated_pure_pursuit_controller.cpp#L324-L344
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should break that logic out into a separate function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would
setPlan
do that? E.g. its a new plan given. The 2 cases is that there's that delay you mention or its a replan during robot execution.The state reset if the time is too long seems like a better fit to be executed in
setPlan
than in this function