Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goal pose stamp #4854

Merged

Conversation

redvinaa
Copy link
Contributor

@redvinaa redvinaa commented Jan 15, 2025

Follow-up on #4822

Description of contribution in a few bullet points

  • There was a bug in the previous PR: the MPPI critics goal pose now uses stamp from global_path, which gets outdated by the TF buffer, and then fails to transform the goal pose.
  • This doesn't come up if the plan is replanned frequently.
  • As a solution, this PR uses the robot_pose.stamp, which gets updated frequently.

Description of documentation updates required from your changes

  • None required

Description of how this change was tested

  • In a custom simulation and on real robot, on the humble branch.

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Signed-off-by: redvinaa <redvinaa@gmail.com>
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be manually backported for Humble's version. I can do Jazzy/Rolling

@SteveMacenski SteveMacenski merged commit 694a222 into ros-navigation:main Jan 15, 2025
9 of 10 checks passed
mergify bot pushed a commit that referenced this pull request Jan 15, 2025
Signed-off-by: redvinaa <redvinaa@gmail.com>
(cherry picked from commit 694a222)
@mergify mergify bot mentioned this pull request Jan 15, 2025
7 tasks
SteveMacenski pushed a commit that referenced this pull request Jan 15, 2025
Signed-off-by: redvinaa <redvinaa@gmail.com>
(cherry picked from commit 694a222)

Co-authored-by: Vince Reda <60265874+redvinaa@users.noreply.github.com>
@redvinaa redvinaa mentioned this pull request Jan 15, 2025
RBT22 pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Jan 22, 2025
Signed-off-by: redvinaa <redvinaa@gmail.com>
Signed-off-by: RBT22 <rozgonyibalint@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants