-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ros2 crystal #23
Open
vandanamandlik
wants to merge
33
commits into
ros-perception:ros2-crystal
Choose a base branch
from
vandanamandlik:ros2-crystal
base: ros2-crystal
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ros2 crystal #23
vandanamandlik
wants to merge
33
commits into
ros-perception:ros2-crystal
from
vandanamandlik:ros2-crystal
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These files were not there in sensor_msgs package of ros2 so just copied it from ROS1 and ported to ROS2 here. laser assembler uses convertPointCloudToPointCloud2() function from point_cloud_conversion.h file.
Renamed base_assembler_srv.h to base_assembler_srv.hpp. Also ported both files to ROS2 as per ROS2 migration guide.
and base_assembler_srv.h file to base_assembler_srv.hpp in previous commit so removed it here.
because message_filter.h file from tf2_ros package of bouncy release was not ported to ROS2. so picked it from link https://github.com/ros2/geometry2/blob/ros2/tf2_ros/include/tf2_ros/message_filter.h and fixed some erros related to time conversion.
… part of the communication. Request structure which is the type of the request part of the service Response structure which is the type of the request part of the service
Only porting is done but not tested.
- src/laser_scan_assembler_srv.cpp - src/merge_clouds.cpp - src/point_cloud2_assembler.cpp - src/point_cloud_assembler.cpp - src/point_cloud_assembler_srv.cpp
… to ROS2 and also tested it. non_zero_cloud_test passed successfully.
- Removed commented and unused code.
- Fixed logger issue for bouncy. - Modified message_filter.hpp to work on bouncy.
…pp' because it is changed in filters package. - changed string type variable to std::string type.
- Changed raw pointer to shared pointer in base_assembler.hpp file. - Modified README.md file for crystal (Latest changes of message_filters and launch package are available in crystal release, We can use it directly. So removed that steps from README.md file)
…le in rclcpp::Time class of crystal release.
- Added one known issue and future work.
@vandanamandlik I think most of the comments on your other PR will transfer over to this one. Once we get that PR merged, I'll do a quick pass over this one. |
Updated CMakeLists.txt file from filters package has solved issue. Setting this flag is not more required.
… in laser_assembler package itself. Previously there was separate package to generate laser_assembler.srv
…ssembler.cpp files to ros2. NOTE: These are just ported but not tested as there is no test case to test all these files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ros2-crystal branch is created from ros2-devel.
Then I did following two changes for crystal
Replaced manual conversion of nanoseconds to seconds with function seconds() in message_filter.hpp
Removed manually clone and build steps of message_filters and launch package from readme because now it available in crystal, Changed raw pointer to shared_pointer.
Could you please review it and give your feedback ?