Changed to make provision for using OpenCV 4#507
Closed
Shobuj-Paul wants to merge 2 commits intoros-perception:melodicfrom
Closed
Changed to make provision for using OpenCV 4#507Shobuj-Paul wants to merge 2 commits intoros-perception:melodicfrom
Shobuj-Paul wants to merge 2 commits intoros-perception:melodicfrom
Conversation
The compiler will check for OpenCV 4 in the system before defaulting to OpenCV 3
- cv::Mat.refcount removed in OpenCV3
Contributor
|
Since ROS 1 is EOL now, closing this out. Thanks anyway for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler will check for OpenCV 4 in the system before defaulting to OpenCV 3.
Have also made a few changes in module_opencv2.cpp to cv::Mat.refcount object, since it was removed in OpenCV 3. Passed a separate integer pointer to manage refcount.
Solves #508