Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3 pyside2 key #34243

Merged
merged 4 commits into from
Sep 10, 2022
Merged

Add python3 pyside2 key #34243

merged 4 commits into from
Sep 10, 2022

Conversation

hellantos
Copy link
Contributor

@hellantos hellantos commented Aug 29, 2022

Please add the following dependency to the rosdep database.

Package name:

python3-pyside2

Package Upstream Source:

https://code.qt.io/cgit/pyside/pyside-setup.git/
https://code.qt.io/cgit/pyside/pyside.git/
https://code.qt.io/cgit/pyside/shiboken.git/

Purpose of using this:

The goal of this key is to eventually replace the pyside2 specific portion of python3-qt5-bindings.
This key will install qt python libraries wrapped with PySide2. The key installs the same libraries as python3-pyqt5 see #34246. This is thought to simplify switching between pyqt and pyside2 as python wrapper providers (see ros-visualization/python_qt_binding#114)

It will at least install wrappers for the following qt libraries:

  • qtcore
  • qtgui
  • qthelp
  • qtnetwork
  • qtprintsupport
  • qtsvg
  • qttest
  • qtwidgets
  • qtxml

In addition it will install:

  • shiboken2 and libraries (generator for pyside2 wrappers)

On Fedora the pyside package is not split so this will install all libraries.

Distro packaging links:

Links to Distribution Packages

@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Aug 29, 2022
@nuclearsandwich
Copy link
Member

@ipa-cmh is there a reason that this PR is still in draft? Would you like initial review on that?

@hellantos
Copy link
Contributor Author

@nuclearsandwich
Its part of a bigger restrucutring around qt python bindings - see linked issues. But I think I am ready for review now.

@hellantos hellantos marked this pull request as ready for review August 30, 2022 10:05
@hellantos hellantos requested a review from a team as a code owner August 30, 2022 10:05
@hellantos hellantos changed the title Add python pyside2 key Add python3 pyside2 key Aug 30, 2022
Copy link
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add an entry for opensuse, as suggested by the GitHub Action.

.vscode/settings.json Outdated Show resolved Hide resolved
@hellantos
Copy link
Contributor Author

Will do.

@hellantos hellantos force-pushed the Add-python-pyside2-key branch from 5931df9 to 1d01f0b Compare September 2, 2022 07:30
@hellantos
Copy link
Contributor Author

Could you also add an entry for opensuse, as suggested by the GitHub Action.

Opensuse seems to only distribute shiboken6 and not shiboken2. I did not find a package, that distributes the necessary shiboken binaries. So I would rather not add the key at all for opensuse.

@tfoote tfoote merged commit 22187d1 into ros:master Sep 10, 2022
@hellantos hellantos deleted the Add-python-pyside2-key branch June 14, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants