Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qtpy for rhel #34247

Merged
merged 4 commits into from
Sep 26, 2022
Merged

Add qtpy for rhel #34247

merged 4 commits into from
Sep 26, 2022

Conversation

hellantos
Copy link
Contributor

Please add the following dependency to the rosdep database.

Package name:

python3-qtpy

Package Upstream Source:

https://github.com/spyder-ide/qtpy

Purpose of using this:

Add support for RHEL. See ros-visualization/python_qt_binding#114

Distro packaging links:

Links to Distribution Packages

Christoph Hellmann Santos added 2 commits August 29, 2022 17:56
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Aug 29, 2022
@hellantos hellantos marked this pull request as ready for review August 30, 2022 10:01
@hellantos hellantos requested a review from a team as a code owner August 30, 2022 10:01
Copy link
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Mind adding an entry for fedora as well?

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need the fixes that @cottsay pointed out, then this will be good.

@jacobperron jacobperron added the changes requested Maintainers have asked for changes to the pull request label Sep 20, 2022
Co-authored-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay removed the changes requested Maintainers have asked for changes to the pull request label Sep 26, 2022
@clalancette clalancette merged commit 1108790 into ros:master Sep 26, 2022
@hellantos hellantos deleted the add-qtpy-key branch June 14, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants