Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plotjuggler: 3.8.6-2 in 'noetic/distribution.yaml' [bloom] #39484

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

facontidavide
Copy link
Contributor

Increasing version of package(s) in repository plotjuggler to 3.8.6-2:

plotjuggler

* fix issue #906 <https://github.com/facontidavide/PlotJuggler/issues/906>: support nanoseconds timestamp in csv
* fix issue #904 <https://github.com/facontidavide/PlotJuggler/issues/904>: wring ROS odometry parsing
* add moving variance
* Contributors: Davide Faconti

@github-actions github-actions bot added the noetic Issue/PR is for the ROS 1 Noetic distribution label Jan 9, 2024
@mjcarroll
Copy link
Member

Holding for Noetic sync

@mjcarroll mjcarroll added the held for sync Issue/PR has been held because the distribution is in a sync hold label Jan 10, 2024
@peci1
Copy link
Contributor

peci1 commented Jan 10, 2024

@mjcarroll We need this fix in Noetic. Please consider including it in the current sync. It fixes bug facontidavide/PlotJuggler#904 which makes PJ largely unusable in Noetic. If it weren't fixed, we'd have the second month in a row without PJ!

@facontidavide It'd also be great to have facontidavide/PlotJuggler#908 included in the release as it is also an important bug that needs to be fixed. But maybe it's not as crucial, I can't assess the gravity of the problem.

@facontidavide
Copy link
Contributor Author

They are both fixed in this release

@peci1
Copy link
Contributor

peci1 commented Jan 10, 2024

Ah, good. It's not apparent from the changelog that the quaternion fix is also included in 3.8.6.

@mjcarroll
Copy link
Member

@sloretz to be considered

Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convinced!

@sloretz sloretz merged commit 98f5108 into ros:master Jan 10, 2024
4 checks passed
@facontidavide
Copy link
Contributor Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
held for sync Issue/PR has been held because the distribution is in a sync hold noetic Issue/PR is for the ROS 1 Noetic distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants