Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python3-pyotp #42428

Merged
merged 6 commits into from
Sep 25, 2024
Merged

add python3-pyotp #42428

merged 6 commits into from
Sep 25, 2024

Conversation

lennewbrook
Copy link
Contributor

added pyotp to python.yaml in  rosdep
Add python3-pyotp package
@lennewbrook lennewbrook requested a review from a team as a code owner August 13, 2024 08:51
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Aug 13, 2024
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it is available for RHEL-9

rosdep/python.yaml Show resolved Hide resolved
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reasons unrelated to this PR, this needs a rebase, then it should pass CI.

Copy link

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Sep 11, 2024
@sloretz sloretz dismissed clalancette’s stale review September 19, 2024 17:00

Rebased since review

rhel:
'*': [python3-pyotp]
'8': null
opensuse: [python3-pyotp]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI is failing here:

    ERR: list out of alphabetical order line 8314.  'opensuse' should come before 'rhel'

@sloretz sloretz added changes requested Maintainers have asked for changes to the pull request and removed stale Issue/PR hasn't been active in a while and may be closed. labels Sep 19, 2024
@audrow audrow merged commit 22c80e7 into ros:master Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants